Upgrade datrie to 0.8+, but not yet for Python 3.8 #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 90.60% 90.91% +0.30%
==========================================
Files 50 50
Lines 6983 6964 -19
Branches 1328 1328
==========================================
+ Hits 6327 6331 +4
+ Misses 497 474 -23
Partials 159 159
Continue to review full report at Codecov.
|
|
see also #455 just dropping it, which I think is what we should do? |
|
datries 0.8.2 supports py38 and was just pushed to pypi |
|
Thanks, I've updated this PR to require datrie 0.8.2+ and allow it for any CPython version. I also added Python 3.9-dev to Travis CI to check datrie (and html5lib) is okay there too. |
|
No longer needed, re: #455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #442.
The latest datrie 0.8 supports Python 3.7: pytries/datrie#52
But it doesn't yet support Python 3.8: pytries/datrie#73